This paper explores the issues that secondary history teachers on an initial teacher education (ITE) programme in England encounter in attempting to incorporate more cultural and ethnic diversity into the history curriculum. It also assesses the impact that changes in their training course had on their views and pedagogical practice. Using questionnaires and scenario based interviews with three cohorts of trainee teachers, key challenges were identified, which were related to the purposes of teaching history and diversity, appropriate pedagogy and content, dealing with pupils, and teachers' personal concerns. A framework for analysing trainees' stances towards cultural and ethnic diversity based upon a confident-uncertain-uncomfortable continuum was developed. The research revealed that the course had had an impact, although this was in subtle rather than marked ways, which raises further questions about what is possible within the confines of an ITE training programme and the need for additional support beyond the course. (Contains 3 tables, 1 figure and 1 note.)