Twenty studies of the effects of teacher questions on student achievement were reviewed. Internal validity of experiments and integrity of treatments were less adequate than population and ecological validity. Whether teachers used predominantly higher cognitive or predominantly fact questions was found to make little difference in achievement. (RD)